Ticket #936 (closed defect: fixed)

Opened 5 weeks ago

Last modified 5 weeks ago

Off-by-one error in AgaviToolkit::stringBase()

Reported by: felix Owned by: felix
Priority: normal Milestone: 0.11.6
Component: util Version: 0.11.5
Severity: normal Keywords:
Cc: Patch attached: no

Description

AgaviToolkit::stringBase() returns the length of the common substring, but is off by one char, the length reported is one too low.

The method is called in AgaviRouting?, so take care when adapting the returned value.

Attachments

Change History

Changed 5 weeks ago by felix

  • owner changed from david to felix
  • status changed from new to assigned

Changed 5 weeks ago by felix

  • status changed from assigned to closed
  • resolution set to fixed

(In [3350]) - fixes off-by-one error in AgaviToolkit::stringBase() - fixes #936

Changed 5 weeks ago by felix

(In [3355]) Merged revisions 3336,3338-3340,3342-3347,3349-3354 via svnmerge from https://svn.agavi.org/branches/1.0

........

r3336 | felix | 2008-12-01 18:42:21 +0100 (Mon, 01 Dec 2008) | 3 lines

Merge from [3204-3216:branches/felix-testing-implementation/]

........

r3338 | felix | 2008-12-01 19:27:50 +0100 (Mon, 01 Dec 2008) | 2 lines

  • changed the algorithm for creation of the cache name
  • fixes #932

........

r3339 | felix | 2008-12-01 19:30:38 +0100 (Mon, 01 Dec 2008) | 1 line

purely cosmetic changes as per davids sole request

........

r3340 | felix | 2008-12-01 19:31:47 +0100 (Mon, 01 Dec 2008) | 2 lines

........

r3342 | david | 2008-12-01 20:05:55 +0100 (Mon, 01 Dec 2008) | 1 line

merge [3324:3341/branches/0.11]

........

r3343 | david | 2008-12-01 20:32:18 +0100 (Mon, 01 Dec 2008) | 1 line

fixed changelog broken in [3340], refs #932

........

r3344 | david | 2008-12-01 20:44:53 +0100 (Mon, 01 Dec 2008) | 1 line

reverting [3343] as [3340] was wrong in another way, too, refs #932

........

r3345 | david | 2008-12-01 20:45:41 +0100 (Mon, 01 Dec 2008) | 1 line

revert broken changelog entry from [3340], refs #932

........

r3346 | david | 2008-12-01 20:47:44 +0100 (Mon, 01 Dec 2008) | 1 line

CHANGELOG for #932, refs #932, see [3340], [3343], [3344], [3345]

........

r3347 | david | 2008-12-01 21:05:00 +0100 (Mon, 01 Dec 2008) | 1 line

adding configuration file path to header comments in compiled files if possible, closes #938 and refs #932

........

r3349 | david | 2008-12-01 21:17:45 +0100 (Mon, 01 Dec 2008) | 1 line

merge [3342:3348/branches/0.11]

........

r3350 | felix | 2008-12-02 11:48:35 +0100 (Tue, 02 Dec 2008) | 2 lines

  • fixes off-by-one error in AgaviToolkit::stringBase()
  • fixes #936

........

r3351 | felix | 2008-12-02 11:53:26 +0100 (Tue, 02 Dec 2008) | 2 lines

fixes changelog for #936

........

r3352 | david | 2008-12-02 11:57:20 +0100 (Tue, 02 Dec 2008) | 1 line

CHANGELOG entry for the path escaping problems in AgaviConfigCache::getCacheName() fixed along the way in [3338], closes #931 and refs #932

........

r3353 | david | 2008-12-02 12:00:20 +0100 (Tue, 02 Dec 2008) | 1 line

RELEASE_NOTES for new config cache filenames, refs #931, #932, #938

........

r3354 | felix | 2008-12-02 12:13:38 +0100 (Tue, 02 Dec 2008) | 3 lines

  • refactor AgaviToolkit::stringBase() (#935)
  • fixes #935

........

Changed 5 weeks ago by felix

(In [3384]) Merged revisions 3338-3340,3342-3347,3349-3354,3363-3364,3366,3368-3369,3371-3373,3376-3377 via svnmerge from https://svn.agavi.org/branches/1.0

........

r3338 | felix | 2008-12-01 19:27:50 +0100 (Mon, 01 Dec 2008) | 2 lines

  • changed the algorithm for creation of the cache name
  • refs #932

........

r3339 | felix | 2008-12-01 19:30:38 +0100 (Mon, 01 Dec 2008) | 1 line

purely cosmetic changes as per davids sole request

........

r3340 | felix | 2008-12-01 19:31:47 +0100 (Mon, 01 Dec 2008) | 2 lines

........

r3342 | david | 2008-12-01 20:05:55 +0100 (Mon, 01 Dec 2008) | 1 line

merge [3324:3341/branches/0.11]

........

r3343 | david | 2008-12-01 20:32:18 +0100 (Mon, 01 Dec 2008) | 1 line

fixed changelog broken in [3340], refs #932

........

r3344 | david | 2008-12-01 20:44:53 +0100 (Mon, 01 Dec 2008) | 1 line

reverting [3343] as [3340] was wrong in another way, too, refs #932

........

r3345 | david | 2008-12-01 20:45:41 +0100 (Mon, 01 Dec 2008) | 1 line

revert broken changelog entry from [3340], refs #932

........

r3346 | david | 2008-12-01 20:47:44 +0100 (Mon, 01 Dec 2008) | 1 line

CHANGELOG for #932, refs #932, see [3340], [3343], [3344], [3345]

........

r3347 | david | 2008-12-01 21:05:00 +0100 (Mon, 01 Dec 2008) | 1 line

adding configuration file path to header comments in compiled files if possible, refs #938 and refs #932

........

r3349 | david | 2008-12-01 21:17:45 +0100 (Mon, 01 Dec 2008) | 1 line

merge [3342:3348/branches/0.11]

........

r3350 | felix | 2008-12-02 11:48:35 +0100 (Tue, 02 Dec 2008) | 2 lines

  • fixes off-by-one error in AgaviToolkit::stringBase()
  • refs #936

........

r3351 | felix | 2008-12-02 11:53:26 +0100 (Tue, 02 Dec 2008) | 2 lines

fixes changelog for #936

........

r3352 | david | 2008-12-02 11:57:20 +0100 (Tue, 02 Dec 2008) | 1 line

CHANGELOG entry for the path escaping problems in AgaviConfigCache::getCacheName() fixed along the way in [3338], closes #931 and refs #932

........

r3353 | david | 2008-12-02 12:00:20 +0100 (Tue, 02 Dec 2008) | 1 line

RELEASE_NOTES for new config cache filenames, refs #931, #932, #938

........

r3354 | felix | 2008-12-02 12:13:38 +0100 (Tue, 02 Dec 2008) | 3 lines

  • refactor AgaviToolkit::stringBase() (#935)
  • refs #935

........

r3363 | david | 2008-12-02 18:15:55 +0100 (Tue, 02 Dec 2008) | 1 line

Allow optional marshalling of document/literal wrapped request and response elements, closes #940

........

r3364 | david | 2008-12-02 18:16:29 +0100 (Tue, 02 Dec 2008) | 1 line

case fix, refs #935

........

r3366 | david | 2008-12-02 18:33:34 +0100 (Tue, 02 Dec 2008) | 1 line

merge [3349:3365/branches/0.11]

........

r3368 | david | 2008-12-02 18:44:32 +0100 (Tue, 02 Dec 2008) | 1 line

ported [3366:3367/branches/0.11]

........

r3369 | david | 2008-12-02 18:48:52 +0100 (Tue, 02 Dec 2008) | 1 line

fixing PHPUnit external to specific revision, refs #380

........

r3371 | david | 2008-12-02 19:16:11 +0100 (Tue, 02 Dec 2008) | 1 line

ported sample and code template compile/filters/translation configs, forgotten in [3308], refs #519

........

r3372 | david | 2008-12-02 19:31:33 +0100 (Tue, 02 Dec 2008) | 1 line

ported test config files to new handlers, forgotten in [3140], [3188] and [3308], refs #519 (old tests are intentionally left untouched)

........

r3373 | david | 2008-12-02 19:52:45 +0100 (Tue, 02 Dec 2008) | 1 line

fixed tests broken since [3338], one of them still failing on non-Windows platforms due to basename() behavior and missing normalization of backslash path names, pending further discussion, refs #932

........

r3376 | david | 2008-12-02 20:06:15 +0100 (Tue, 02 Dec 2008) | 1 line

merge [3368:3375/branches/0.11]

........

r3377 | david | 2008-12-03 10:48:09 +0100 (Wed, 03 Dec 2008) | 1 line

made AgaviConfigCache::getCacheName() tests skipping certain parts if OS is not Windows, refs #932

........

Add/Change #936 (Off-by-one error in AgaviToolkit::stringBase())

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.